From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 28 Oct 2008 03:35:04 GMT
Subject: Re: [PATCH] Add mksnpath and git_snpath which allow to specify the output buffer
Message-ID: <7vd4hlgzo7.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081027064537.GA4751@blimp.localdomain>

Alex Riesen <raa.lkml@gmail.com> writes:

> Junio C Hamano, Mon, Oct 27, 2008 06:07:24 +0100:
>> Where is git_snpath() used?
>
> Nowhere yet, but it should replace git_path in every call where the
> result is not used immediately. Which, as the story with cygwin
> porting shows, can be sometimes not quite trivial (who could suspect
> lstat(2) will have application local side effects?).
>
> Maybe I should resend the patches without it, following by patches
> introducing git_snpath and replacing calls to git_path.

I took the liberty of doing the first half of just that ;-)

I also think this series of fix is maint-worthy, and splitted the last one
into two so that maint and master can be fixed independently.