Re: [PATCH] Add mksnpath and git_snpath which allow to specify the output buffer
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Oct 28, 2008, 17:31 UTC
- Message-ID
- <20081028173132.GB7054@blimp.localdomain>
- In-Reply-To
- <81b0412b0810280547nf5e6834t4049e92d374926b6@mail.gmail.com>
Alex Riesen, Tue, Oct 28, 2008 13:47:21 +0100:
Show 14 quoted lines
> 2008/10/28 Junio C Hamano <gitster@pobox.com>: > > Alex Riesen <raa.lkml@gmail.com> writes: > >> Maybe I should resend the patches without it, following by patches > >> introducing git_snpath and replacing calls to git_path. > > > > I took the liberty of doing the first half of just that ;-) > > > > Thanks. And am sorry... I did that too, and stupidly forgot to send. > I also considered replacing xstrdup(mkpath) with a function which does > just that (patches 8-9). Patches 1 and 2 are unrelated, will send them > separately. > > FWIW now, I'm sending the patches.
Err... The builtin-revert.c hunk of path 0009 depends on the patch I sent later: "Plug a memleak in builtin-revert". The patch removed const in front of "char *defmsg".