Re: [PATCH] Add mksnpath and git_snpath which allow to specify the output buffer
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Oct 27, 2008, 06:45 UTC
- Message-ID
- <20081027064537.GA4751@blimp.localdomain>
- In-Reply-To
- <7v8wsak4mr.fsf@gitster.siamese.dyndns.org>
Junio C Hamano, Mon, Oct 27, 2008 06:07:24 +0100:
> Where is git_snpath() used?
Nowhere yet, but it should replace git_path in every call where the result is not used immediately. Which, as the story with cygwin porting shows, can be sometimes not quite trivial (who could suspect lstat(2) will have application local side effects?).
Maybe I should resend the patches without it, following by patches introducing git_snpath and replacing calls to git_path.
Maybe Linus should be sued for introducing the function in the first place.