Re: [PATCH] t3700-add: add a POSIXPERM prerequisite to a new test

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 22, 2009, 07:42 UTC
Message-ID: <7vab40g1dv.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4A3F331E.5080301@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 22 quoted lines

> From: Johannes Sixt <j6t@kdbg.org>
>
> The new test does a 'chmod 0', which does not have the intended
> effect on Windows.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> Stephen Boyd schrieb:
>> Junio C Hamano wrote:
>>> Why do you need POSIXPERM for this?
>> 
>> I copied a previous test and it was doing chmod 0 foo2.
> ...
>> +test_expect_success POSIXPERM '--no-ignore-errors overrides config' '
>> +       git config add.ignore-errors 1 &&
>> +       git reset --hard &&
>> +       date >foo1 &&
>> +       date >foo2 &&
>> +       chmod 0 foo2 &&
>
> I can only guess that you missed this 'chmod 0' despite Stephen's
> explanation and dropped POSIXPERM when you applied the patch.

Actually, I wanted to add the test to 'maint' and 'maint-$v' for values of $v that are lower than 1.6.3, so I did want to drop POSIXPERM on the branch the patch initially applied; I forgot to make an evil merge when I merged the result up, crossing 1.6.2/1.6.3 boundary..

Will queue on 'maint'.  Thanks.