[PATCH] t3700-add: add a POSIXPERM prerequisite to a new test
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Jun 22, 2009, 07:30 UTC
- Message-ID
- <4A3F331E.5080301@viscovery.net>
- In-Reply-To
- <4A3A8E73.1010807@gmail.com>
From: Johannes Sixt <j6t@kdbg.org>
The new test does a 'chmod 0', which does not have the intended effect on Windows.
Signed-off-by: Johannes Sixt <j6t@kdbg.org> --- Stephen Boyd schrieb:
> Junio C Hamano wrote: >> Why do you need POSIXPERM for this? > > I copied a previous test and it was doing chmod 0 foo2.
...
Show 6 quoted lines
> +test_expect_success POSIXPERM '--no-ignore-errors overrides config' ' > + git config add.ignore-errors 1 && > + git reset --hard && > + date >foo1 && > + date >foo2 && > + chmod 0 foo2 &&
I can only guess that you missed this 'chmod 0' despite Stephen's explanation and dropped POSIXPERM when you applied the patch.
-- Hannes
t/t3700-add.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t3700-add.sh b/t/t3700-add.sh index 6ae5a2c..85eb0fb 100755 --- a/t/t3700-add.sh +++ b/t/t3700-add.sh @@ -223,7 +223,7 @@ test_expect_success POSIXPERM 'git add ' rm -f foo2 -test_expect_success '--no-ignore-errors overrides config' ' +test_expect_success POSIXPERM '--no-ignore-errors overrides config' ' git config add.ignore-errors 1 && git reset --hard && date >foo1 &&
-- 1.6.3.2.1450.g146e1