git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add: allow configurations to be overriden by command line

From
Stephen Boyd <bebarino@gmail.com>
Date
Jun 18, 2009, 18:58 UTC
Message-ID
<4A3A8E73.1010807@gmail.com>
In-Reply-To
<7veitho0gu.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Why do you need POSIXPERM for this?
>   

I copied a previous test and it was doing chmod 0 foo2. This test is actually depending on that earlier test which is probably bad style, sorry. Here's a more insulated version.

diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index 6ce8256..66bdc24 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -221,6 +221,19 @@ test_expect_success POSIXPERM 'git add (add.ignore-errors = false)' '
        test_must_fail git add --verbose . &&
        ! ( git ls-files foo1 | grep foo1 )
 '
+rm -f foo2
+
+test_expect_success POSIXPERM '--no-ignore-errors overrides config' '
+       git config add.ignore-errors 1 &&
+       git reset --hard &&
+       date >foo1 &&
+       date >foo2 &&
+       chmod 0 foo2 &&
+       test_must_fail git add --verbose --no-ignore-errors . &&
+       ! ( git ls-files foo1 | grep foo1 ) &&
+       git config add.ignore-errors 0
+'
+rm -f foo2
 
 test_expect_success BSLASHPSPEC "git add 'fo\\[ou\\]bar' ignores foobar" '
        git reset --hard &&
Previous: Junio C HamanoNext: Johannes Sixt
Message 5 of 7 in “add: allow configurations to be overriden by command line”
  1. add: allow configurations to be overriden by command lineStephen Boyd, Jun 18, 2009
  2. Junio C HamanoJun 18, 2009
  3. Stephen BoydJun 18, 2009
  4. Junio C HamanoJun 18, 2009
  5. Stephen BoydJun 18, 2009
  6. t3700-add: add a POSIXPERM prerequisite to a new testJohannes Sixt, Jun 22, 2009
  7. Junio C HamanoJun 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.