[PATCH] add: allow configurations to be overriden by command line
- From
Stephen Boyd <bebarino@gmail.com>
- Date
- Jun 18, 2009, 09:17 UTC
- Message-ID
- <1245316674-32377-1-git-send-email-bebarino@gmail.com>
Don't call git_config after parsing the command line options, otherwise the config settings will override any settings made by the command line.
This can be seen by setting add.ignore_errors and then specifying --no-ignore-errors when using git-add.
Signed-off-by: Stephen Boyd <bebarino@gmail.com> --- builtin-add.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin-add.c b/builtin-add.c index c1b229a..56e5221 100644 --- a/builtin-add.c +++ b/builtin-add.c @@ -298,6 +298,8 @@ int cmd_add(int argc, const char **argv, const char *prefix) int add_new_files; int require_pathspec; + git_config(add_config, NULL); + argc = parse_options(argc, argv, prefix, builtin_add_options, builtin_add_usage, PARSE_OPT_KEEP_ARGV0); if (patch_interactive) @@ -305,8 +307,6 @@ int cmd_add(int argc, const char **argv, const char *prefix) if (add_interactive) exit(interactive_add(argc - 1, argv + 1, prefix)); - git_config(add_config, NULL); - if (edit_interactive) return(edit_patch(argc, argv, prefix)); argc--;
-- 1.6.3.2.306.g4f4fa