Re: [PATCH v5 15/16] remote-svn: add marks-file regeneration
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 20, 2012, 23:20 UTC
- Message-ID
- <7va9xpgngk.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7vehn1gocn.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
> I think you meant something like:
>
> init_notes(NULL, notes_ref, NULL, 0);
> marksfile = fopen(marksfilename, "r");
> if (!marksfile) {
> regenerate_marks(marksfilename);
> marksfile = fopen(marksfilename, "r");
> if (!marksfile)
> die("cannot read marks file!");
> } else {
> ...
>
> Also there is another call to regenerate_marks() without any
> argument. Has this even been compile-tested?I've made regenerate_marks() to take (void) parameter list, as marksfilename is a file scope static and visible to everybody, and applied something like the above and queued the result in 'pu'.