Re: [PATCH v5 15/16] remote-svn: add marks-file regeneration

From: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Date: Aug 21, 2012, 09:47 UTC
Message-ID: <1894713.otuKr9xS8H@flomedio>
In-Reply-To: <7va9xpgngk.fsf@alter.siamese.dyndns.org>

On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:

Show 9 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> > I think you meant something like:
> > 
> >       init_notes(NULL, notes_ref, NULL, 0);
> >
> >         marksfile = fopen(marksfilename, "r");
> >         if (!marksfile) {
> >               regenerate_marks(marksfilename);
> >                 marksfile = fopen(marksfilename, "r");

Btw, this is FILE* is nowhere closed in your fixuped version in fa/remote-svn.

Show 6 quoted lines

> >                 if (!marksfile)
> >
> >                       die("cannot read marks file!");
> >       } else {
> >
> >               ...

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.