From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 20 Aug 2012 23:20:27 GMT
Subject: Re: [PATCH v5 15/16] remote-svn: add marks-file regeneration
Message-ID: <7va9xpgngk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vehn1gocn.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> I think you meant something like:
>
> 	init_notes(NULL, notes_ref, NULL, 0);
>         marksfile = fopen(marksfilename, "r");
>         if (!marksfile) {
>         	regenerate_marks(marksfilename);
>                 marksfile = fopen(marksfilename, "r");
>                 if (!marksfile)
> 	                die("cannot read marks file!");
> 	} else {
>         	...
>
> Also there is another call to regenerate_marks() without any
> argument.  Has this even been compile-tested?

I've made regenerate_marks() to take (void) parameter list, as
marksfilename is a file scope static and visible to everybody, and
applied something like the above and queued the result in 'pu'.