git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 02/16] Add git-remote-testsvn to Makefile.

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 20, 2012, 22:19 UTC
Message-ID
<7vehn1i4uk.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1345499542-15536-3-git-send-email-florian.achleitner.2.6.31@gmail.com>
Florian Achleitner <florian.achleitner.2.6.31@gmail.com> writes:
> Subject: Re: [PATCH v5 02/16] Add git-remote-testsvn to Makefile.
Adds '.' at the end of the title.
Show 24 quoted lines
> The link-rule is a copy of the standard git$X rule but adds VCSSVN_LIB.
>
> Signed-off-by: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
> ---
>  Makefile |    5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 6b0c961..fb5cdcf 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -477,6 +477,7 @@ PROGRAM_OBJS += sh-i18n--envsubst.o
>  PROGRAM_OBJS += shell.o
>  PROGRAM_OBJS += show-index.o
>  PROGRAM_OBJS += upload-pack.o
> +PROGRAM_OBJS += remote-testsvn.o
>  
>  # Binary suffix, set to .exe for Windows builds
>  X =
> @@ -2352,6 +2353,10 @@ git-http-push$X: revision.o http.o http-push.o GIT-LDFLAGS $(GITLIBS)
>  	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
>  		$(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT)
>  
> +git-remote-testsvn$X: remote-testsvn.o GIT-LDFLAGS $(GITLIBS) 
Adds trailing whitespace.
Show 6 quoted lines
> +	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) $(LIBS) \
> +	$(VCSSVN_LIB)
> +
>  $(REMOTE_CURL_ALIASES): $(REMOTE_CURL_PRIMARY)
>  	$(QUIET_LNCP)$(RM) $@ && \
>  	ln $< $@ 2>/dev/null || \

But I think moving this to the top-level made things a lot simpler. Excellent.

Previous: Junio C Hamano
Message 24 of 24 in “GSOC remote-svn”
  1. 00/16 GSOC remote-svnFlorian Achleitner, Aug 20, 2012
  2. 01/16 Implement a remote helper for svn in CFlorian Achleitner, Aug 20, 2012
  3. 02/16 Add git-remote-testsvn to Makefile.Florian Achleitner, Aug 20, 2012
  4. 03/16 Add svndump_init_fd to allow reading dumps from arbitrary FDsFlorian Achleitner, Aug 20, 2012
  5. 04/16 Add argv_array_detach and argv_array_free_detachedFlorian Achleitner, Aug 20, 2012
  6. 05/16 Connect fast-import to the remote-helper via pipe, adding 'bidi-import' capabilityFlorian Achleitner, Aug 20, 2012
  7. 06/16 Add documentation for the 'bidi-import' capability of remote-helpersFlorian Achleitner, Aug 20, 2012
  8. 07/16 When debug==1, start fast-import with "--stats" instead of "--quiet"Florian Achleitner, Aug 20, 2012
  9. 08/16 remote-svn, vcs-svn: Enable fetching to private refsFlorian Achleitner, Aug 20, 2012
  10. 09/16 Allow reading svn dumps from files via file:// urlsFlorian Achleitner, Aug 20, 2012
  11. 10/16 vcs-svn: add fast_export_note to create notesFlorian Achleitner, Aug 20, 2012
  12. 11/16 Create a note for every imported commit containing svn metadataFlorian Achleitner, Aug 20, 2012
  13. 12/16 remote-svn: Activate import/export-marks for fast-importFlorian Achleitner, Aug 20, 2012
  14. 13/16 remote-svn: add incremental importFlorian Achleitner, Aug 20, 2012
  15. 14/16 Add a svnrdump-simulator replaying a dump file for testingFlorian Achleitner, Aug 20, 2012
  16. 15/16 remote-svn: add marks-file regenerationFlorian Achleitner, Aug 20, 2012
  17. 16/16 Add a test script for remote-svnFlorian Achleitner, Aug 20, 2012
  18. Junio C HamanoAug 20, 2012
  19. Junio C HamanoAug 20, 2012
  20. Florian AchleitnerAug 21, 2012
  21. Florian AchleitnerAug 21, 2012
  22. Junio C HamanoAug 21, 2012
  23. Junio C HamanoAug 20, 2012
  24. Junio C HamanoAug 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.