git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin

From
Junio C Hamano <junkio@cox.net>
Date
Sep 7, 2005, 05:47 UTC
Message-ID
<7v8xy9bfaj.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20050907030855.9278.qmail@web34313.mail.mud.yahoo.com>
Mark Allen <mrallen1@yahoo.com> writes:
> This trivial patch creates $(LIBS) and sets it to iconv in
> tools/Makefile because MacOS 10.4 [gcc 4.0] gets cranky about
> libiconv routines referenced in mailinfo.c (convert_to_utf8)
> and no library pointer to link the symbols against.

I'd do this slightly differently. Could you take a look at what I have in the "proposed updates" branch, especially "Flatten tools/ directory" commit? What I am aiming for is to have platform specific ifeq() thing in only one place.

Previous: Mark AllenNext: Mark Allen
Message 2 of 4 in “Add $(LIBS) and set libiconv in tools/Makefile for Darwin”
  1. Add $(LIBS) and set libiconv in tools/Makefile for DarwinMark Allen, Sep 7, 2005
  2. Junio C HamanoSep 7, 2005
  3. Mark AllenSep 7, 2005
  4. Junio C HamanoSep 7, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.