git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin

From
MAMark Allen <mrallen1@yahoo.com>
Date
Sep 7, 2005, 03:08 UTC
Message-ID
<20050907030855.9278.qmail@web34313.mail.mud.yahoo.com>
[PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin 

This trivial patch creates $(LIBS) and sets it to iconv in tools/Makefile because MacOS 10.4 [gcc 4.0] gets cranky about libiconv routines referenced in mailinfo.c (convert_to_utf8) and no library pointer to link the symbols against.

I haven't tested this on Linux yet (but I will tomorrow when I get into work).
Signed-off-by: Mark Allen <mrallen1@yahoo.com>
[PATCH] Add LIBS field and populate with iconv to tools/Makefile for Darwin 

OS X.4 [gcc 4.0] gets cranky about iconv data structures and no library pointer to link the symbols against.

Signed-off-by: Mark Allen <mrallen1@yahoo.com>
---
 tools/Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
44865be29a83e2b4b0bf65c6dae427203b7be9b9
diff --git a/tools/Makefile b/tools/Makefile
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -7,13 +7,14 @@ ALL_CFLAGS = $(CFLAGS)
 INSTALL=install
 prefix=$(HOME)
 bindir=$(prefix)/bin
+LIBS=iconv
 # DESTDIR=
 
 PROGRAMS=git-mailsplit git-mailinfo
 SCRIPTS=git-applymbox git-applypatch
 
 git-%: %.c
-	$(CC) $(ALL_CFLAGS) -o $@ $(filter %.c,$^)
+	$(CC) $(ALL_CFLAGS) -l$(LIBS) -o $@ $(filter %.c,$^)
 
 all: $(PROGRAMS)
 
Next: Junio C Hamano
Message 1 of 4 in “Add $(LIBS) and set libiconv in tools/Makefile for Darwin”
  1. Add $(LIBS) and set libiconv in tools/Makefile for DarwinMark Allen, Sep 7, 2005
  2. Junio C HamanoSep 7, 2005
  3. Mark AllenSep 7, 2005
  4. Junio C HamanoSep 7, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.