Re: [PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin

From: Mark Allen <mrallen1@yahoo.com>
Date: Sep 7, 2005, 15:01 UTC
Message-ID: <20050907150103.11609.qmail@web34311.mail.mud.yahoo.com>
In-Reply-To: <7v8xy9bfaj.fsf@assigned-by-dhcp.cox.net>

--- Junio C Hamano <junkio@cox.net> wrote:

> I'd do this slightly differently.  Could you take a look at what
> I have in the "proposed updates" branch, especially "Flatten
> tools/ directory" commit?  What I am aiming for is to have
> platform specific ifeq() thing in only one place.

Looks good to me, Junio.  There's a very small typo in your commit though. :-)

Cheers,

--Mark

---

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -149,7 +149,7 @@ else
        MOZILLA_SHA1=1
        OPENSSL_LIBSSL=
 endif
-ifdef NEEDS_SSL_WITH_CRIPTO
+ifdef NEEDS_SSL_WITH_CRYPTO
        LIB_4_CRYPTO = -lcrypto -lssl
 else
        LIB_4_CRYPTO = -lcrypto