From: Junio C Hamano Date: Wed, 07 Sep 2005 05:47:00 GMT Subject: Re: [PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin Message-ID: <7v8xy9bfaj.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20050907030855.9278.qmail@web34313.mail.mud.yahoo.com> Mark Allen writes: > This trivial patch creates $(LIBS) and sets it to iconv in > tools/Makefile because MacOS 10.4 [gcc 4.0] gets cranky about > libiconv routines referenced in mailinfo.c (convert_to_utf8) > and no library pointer to link the symbols against. I'd do this slightly differently. Could you take a look at what I have in the "proposed updates" branch, especially "Flatten tools/ directory" commit? What I am aiming for is to have platform specific ifeq() thing in only one place.