git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] dir: do all size checks before seeking back and fix file closing

From
Junio C Hamano <junkio@cox.net>
Date
Aug 27, 2006, 02:15 UTC
Message-ID
<7v8xlazzyb.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<7v4pvz11o6.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> writes:
Show 8 quoted lines
> Linus Torvalds <torvalds@osdl.org> writes:
>
>> Now, admittedly it's wrong because another bad habit Junio picked up 
>> (doing comparisons with constants in the wrong order)
>
> I think you misunderstand the rationale used to encourage the
> comparison used there.  It does not have anything to do with
> having comparison on the left.
s/comparison/constant/; I cannot spell.
Previous: Junio C HamanoNext: Linus Torvalds
Message 7 of 10 in “dir: do all size checks before seeking back and fix file closing”
  1. dir: do all size checks before seeking back and fix file closingJonas Fonseca, Aug 26, 2006
  2. Mitchell Blank JrAug 26, 2006
  3. Jonas FonsecaAug 26, 2006
  4. Linus TorvaldsAug 26, 2006
  5. Jakub NarebskiAug 26, 2006
  6. Junio C HamanoAug 27, 2006
  7. Junio C HamanoAug 27, 2006
  8. Linus TorvaldsAug 27, 2006
  9. Junio C HamanoAug 27, 2006
  10. Use fstat instead of fseekJonas Fonseca, Aug 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.