From: Junio C Hamano Date: Sun, 27 Aug 2006 02:15:24 GMT Subject: Re: [PATCH] dir: do all size checks before seeking back and fix file closing Message-ID: <7v8xlazzyb.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <7v4pvz11o6.fsf@assigned-by-dhcp.cox.net> Junio C Hamano writes: > Linus Torvalds writes: > >> Now, admittedly it's wrong because another bad habit Junio picked up >> (doing comparisons with constants in the wrong order) > > I think you misunderstand the rationale used to encourage the > comparison used there. It does not have anything to do with > having comparison on the left. s/comparison/constant/; I cannot spell.