Re: [PATCH] dir: do all size checks before seeking back and fix file closing

From: Junio C Hamano <junkio@cox.net>
Date: Aug 27, 2006, 03:04 UTC
Message-ID: <7vy7tayj4d.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0608261931460.11811@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 7 quoted lines

>> The comparison order is done in textual order.  You list smaller
>> things on the left and then larger things on the right (iow, you
>> almost never use >= or >).
>
> Ahh. A number of people do the "0 == x" thing, because they want to be 
> caught if they use "=" instead of "==" by mistake. I thought it was the 
> same thing.

The rest is repeating what you said 15 months ago, so I did not quote that part, but interested parties can follow this thread:

http://thread.gmane.org/gmane.comp.version-control.git/3907/focus=4126