git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] dir: do all size checks before seeking back and fix file closing

From
MJMitchell Blank Jr <mitch@sfgoth.com>
Date
Aug 26, 2006, 18:43 UTC
Message-ID
<20060826184330.GA34439@gaz.sfgoth.com>
In-Reply-To
<20060826141709.GC11601@diku.dk>
Jonas Fonseca wrote:
>   err:
> -	if (0 <= fd)
> +	if (0 >= fd)
>  		close(fd);

Could you explain that piece? You now only close "fd" if it's zero (stdin) or negative (invalid). The old code (close if its >=0) make more sense.

-Mitch
Previous: Jonas FonsecaNext: Jonas Fonseca
Message 2 of 10 in “dir: do all size checks before seeking back and fix file closing”
  1. dir: do all size checks before seeking back and fix file closingJonas Fonseca, Aug 26, 2006
  2. Mitchell Blank JrAug 26, 2006
  3. Jonas FonsecaAug 26, 2006
  4. Linus TorvaldsAug 26, 2006
  5. Jakub NarebskiAug 26, 2006
  6. Junio C HamanoAug 27, 2006
  7. Junio C HamanoAug 27, 2006
  8. Linus TorvaldsAug 27, 2006
  9. Junio C HamanoAug 27, 2006
  10. Use fstat instead of fseekJonas Fonseca, Aug 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.