git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/6] convert object type handling from a string to a number

From
Junio C Hamano <junkio@cox.net>
Date
Feb 27, 2007, 10:53 UTC
Message-ID
<7v8xejhnwd.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<7vejobhor2.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> writes:
Show 11 quoted lines
> Nicolas Pitre <nico@cam.org> writes:
>
>> We currently have two parallel notation for dealing with object types
>> in the code: a string and a numerical value.  One of them is obviously
>> redundent, and the most used one requires more stack space and a bunch
>> of strcmp() all over the place.
>>
>> This is an initial step for the removal of the version using a char array
>> found in object reading code paths.  The patch is unfortunately large but
>> there is no sane way to split it in smaller parts without breaking the
>> system.
Will your next step be to convert write_sha1_file() and friends?
Previous: Junio C HamanoNext: Nicolas Pitre
Message 9 of 16 in “various cleanups”
  1. Nicolas PitreFeb 26, 2007
  2. 1/6 sha1_file.c: cleanup hdr usageNicolas Pitre, Feb 26, 2007
  3. 2/6 sha1_file.c: cleanup "offset" usageNicolas Pitre, Feb 26, 2007
  4. 3/6 sha1_file.c: don't ignore an error condition in sha1_loose_object_info()Nicolas Pitre, Feb 26, 2007
  5. 4/6 formalize typename(), and add its reverse type_from_string()Nicolas Pitre, Feb 26, 2007
  6. 5/6 convert object type handling from a string to a numberNicolas Pitre, Feb 26, 2007
  7. 6/6 get rid of lookup_object_type()Nicolas Pitre, Feb 26, 2007
  8. Junio C HamanoFeb 27, 2007
  9. Junio C HamanoFeb 27, 2007
  10. Nicolas PitreFeb 27, 2007
  11. Nicolas PitreFeb 27, 2007
  12. Linus TorvaldsFeb 27, 2007
  13. Nicolas PitreFeb 27, 2007
  14. Shawn O. PearceFeb 27, 2007
  15. Nicolas PitreFeb 27, 2007
  16. Shawn O. PearceFeb 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.