Re: [PATCH 5/6] convert object type handling from a string to a number

From: Nicolas Pitre <nico@cam.org>
Date: Feb 27, 2007, 14:06 UTC
Message-ID: <alpine.LRH.0.82.0702270858510.29426@xanadu.home>
In-Reply-To: <7v8xejhnwd.fsf@assigned-by-dhcp.cox.net>

On Tue, 27 Feb 2007, Junio C Hamano wrote:

Show 15 quoted lines

> Junio C Hamano <junkio@cox.net> writes:
> 
> > Nicolas Pitre <nico@cam.org> writes:
> >
> >> We currently have two parallel notation for dealing with object types
> >> in the code: a string and a numerical value.  One of them is obviously
> >> redundent, and the most used one requires more stack space and a bunch
> >> of strcmp() all over the place.
> >>
> >> This is an initial step for the removal of the version using a char array
> >> found in object reading code paths.  The patch is unfortunately large but
> >> there is no sane way to split it in smaller parts without breaking the
> >> system.
> 
> Will your next step be to convert write_sha1_file() and friends?

Yes, eventually.

At least the write paths don't have those strcpy()/strcmp() everywhere and no temporary char arrays on the stack. But for uniformity they have to be converted as well.

Nicolas