From: Junio C Hamano Date: Tue, 27 Feb 2007 10:53:54 GMT Subject: Re: [PATCH 5/6] convert object type handling from a string to a number Message-ID: <7v8xejhnwd.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <7vejobhor2.fsf@assigned-by-dhcp.cox.net> Junio C Hamano writes: > Nicolas Pitre writes: > >> We currently have two parallel notation for dealing with object types >> in the code: a string and a numerical value. One of them is obviously >> redundent, and the most used one requires more stack space and a bunch >> of strcmp() all over the place. >> >> This is an initial step for the removal of the version using a char array >> found in object reading code paths. The patch is unfortunately large but >> there is no sane way to split it in smaller parts without breaking the >> system. Will your next step be to convert write_sha1_file() and friends?