git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/6] convert object type handling from a string to a number

From
Nicolas Pitre <nico@cam.org>
Date
Feb 27, 2007, 15:33 UTC
Message-ID
<alpine.LRH.0.82.0702271029060.29426@xanadu.home>
In-Reply-To
<20070227150126.GA3230@spearce.org>
On Tue, 27 Feb 2007, Shawn O. Pearce wrote:
Show 8 quoted lines
> Junio C Hamano <junkio@cox.net> wrote:
> > I am wondering if "enum object_type" and signed comparison here
> > are compatible.  sha1_object_info() is of type "int" so that is
> > clearly signed, but are we safe assuming this would not result
> > in "type is unsigned and condition is always false"?
> 
> See my recent patch; I actually rewrote those hunks to use OBJ_BAD
> rather than < 0, as this cleans things up for my packv4.

I'd prefer if < 0 remained though. That way we can use negative values for any kind of error status. And for kernel hackers this is a pretty common idiom. And it uses less line realestate.

Actually OBJ_BAD could be assigned the value -1 and OBJ_MAX used to verify the object number is within range. That would unify things and make the code a bit more logical.

Nicolas
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 15 of 16 in “various cleanups”
  1. Nicolas PitreFeb 26, 2007
  2. 1/6 sha1_file.c: cleanup hdr usageNicolas Pitre, Feb 26, 2007
  3. 2/6 sha1_file.c: cleanup "offset" usageNicolas Pitre, Feb 26, 2007
  4. 3/6 sha1_file.c: don't ignore an error condition in sha1_loose_object_info()Nicolas Pitre, Feb 26, 2007
  5. 4/6 formalize typename(), and add its reverse type_from_string()Nicolas Pitre, Feb 26, 2007
  6. 5/6 convert object type handling from a string to a numberNicolas Pitre, Feb 26, 2007
  7. 6/6 get rid of lookup_object_type()Nicolas Pitre, Feb 26, 2007
  8. Junio C HamanoFeb 27, 2007
  9. Junio C HamanoFeb 27, 2007
  10. Nicolas PitreFeb 27, 2007
  11. Nicolas PitreFeb 27, 2007
  12. Linus TorvaldsFeb 27, 2007
  13. Nicolas PitreFeb 27, 2007
  14. Shawn O. PearceFeb 27, 2007
  15. Nicolas PitreFeb 27, 2007
  16. Shawn O. PearceFeb 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.