git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-daemon: Simplify child management and associated logging by

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 13, 2008, 19:28 UTC
Message-ID
<7v8wv0ogso.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080812225642.GA15265@cuci.nl>
"Stephen R. van den Berg" <srb@cuci.nl> writes:
Show 18 quoted lines
> Junio C Hamano wrote:
>>"Stephen R. van den Berg" <srb@cuci.nl> writes:
>>Sorry, but this does too many things in one patch.
>
> Yes, I know, got carried away.  Then again, the code has a lot of
> overlapping places (spacewise); I kind of leapt from one place to the
> next; you fix one thing, and then the next wart stares you in the face.
> I'll see if I can split it up, if that suits you better.
>
>> - Taking advantage of poll() getting interrupted by SIGCHLD, so that you
>>   do not have to do anything in the signal handler, is so obvious that I
>>   am actually ashamed of not having to think of it the last time we
>>   touched this code.  Is there a poll() that does not return EINTR but
>>   just call the handler and restart after that as if nothing has
>>   happened, I have to wonder...
>
> Only if the signal is set to SIG_IGN on all systems I worked with since
> 1987.

Yeah, rub it in. That's why I said I am actually ashamed that I did not notice that as an obviously much more simpler approach.

Previous: Stephen R. van den BergNext: Alex Riesen
Message 11 of 17 in “git-daemon: SysV needs the signal handler reinstated.”
  1. git-daemon: SysV needs the signal handler reinstated.Stephen R. van den Berg, Aug 12, 2008
  2. git-daemon: Simplify child management and associated logging byStephen R. van den Berg, Aug 12, 2008
  3. Junio C HamanoAug 12, 2008
  4. Stephen R. van den BergAug 12, 2008
  5. git-daemon: Simplify child management and associated logging byStephen R. van den Berg, Aug 12, 2008
  6. git-daemon: Simplify child management and associated logging byStephen R. van den Berg, Aug 13, 2008
  7. Marcus GriepAug 13, 2008
  8. Junio C HamanoAug 13, 2008
  9. Stephen R. van den BergAug 13, 2008
  10. Stephen R. van den BergAug 13, 2008
  11. Junio C HamanoAug 13, 2008
  12. Alex RiesenAug 12, 2008
  13. Stephen R. van den BergAug 12, 2008
  14. Alex RiesenAug 13, 2008
  15. Stephen R. van den BergAug 13, 2008
  16. Andreas EricssonAug 13, 2008
  17. Alex RiesenAug 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.