Re: [PATCH] git-daemon: Simplify child management and associated logging by
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Aug 13, 2008, 06:20 UTC
- Message-ID
- <20080813062008.GA4345@blimp.local>
- In-Reply-To
- <20080812231210.GB15265@cuci.nl>
Stephen R. van den Berg, Wed, Aug 13, 2008 01:12:10 +0200:
Show 14 quoted lines
> Alex Riesen wrote:
> >Stephen R. van den Berg, Tue, Aug 12, 2008 23:25:35 +0200:
> >> @@ -1105,6 +1026,10 @@ int main(int argc, char **argv)
> >> init_timeout = atoi(arg+15);
> >> continue;
>
> >> + if (!prefixcmp(arg, "--max-connections=")) {
> >> + max_connections = atoi(arg+18);
>
> >An error checking wouldn't go amiss. And it can't be done with atoi
> >(consider strtol).
>
> I merely copied the other argument parsing methods, didn't want to
> improve this, just functionally equivalent (will do fine here, IMO).In case of error max_connections will be 0. How does your code handle it? It is a server side program, which supposed to provide reliable service. In this case, an operator mistake is not even noticable until the first request and even than the clients have to complain first.