git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-daemon: Simplify child management and associated logging by

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 13, 2008, 00:20 UTC
Message-ID
<7vvdy5pxz6.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080812225642.GA15265@cuci.nl>
"Stephen R. van den Berg" <srb@cuci.nl> writes:
> Separating it causes two things:
> a. The patches to become dependent on each other in the timeline.
> b. More (redundant) work, because some parts that need to be rewritten, get
>    deleted by the following patch(es).
These are actually desirable properties from reviewability point of view.
Show 8 quoted lines
>> - I see you have a call to vsyslog, which is the first user of the
>>   function.  How portable is it (the patch coming from you, I know
>>   Solaris would have it, and recent 4BSD also would, but what about the
>>   others)?
>
> Cygwin has it, Solaris does, Linux does, MacOSX does.
> AIX and HPUX don't, perhaps.
> I'll see what I can do to avoid it, yet simplify the code.

That's one of the reasons why I asked you to split it to three patches, so that the syslog change can potentially be independently replaced with a better alternative.

In any case, it is already late in the rc cycle; I'd like to apply your earlier "In SysV, signal(SIGCHLD) need to be rearmed" patch and nothing else for now. The clean-up is very attractive but can be done post 1.6.0.

Previous: Marcus GriepNext: Stephen R. van den Berg
Message 8 of 17 in “git-daemon: SysV needs the signal handler reinstated.”
  1. git-daemon: SysV needs the signal handler reinstated.Stephen R. van den Berg, Aug 12, 2008
  2. git-daemon: Simplify child management and associated logging byStephen R. van den Berg, Aug 12, 2008
  3. Junio C HamanoAug 12, 2008
  4. Stephen R. van den BergAug 12, 2008
  5. git-daemon: Simplify child management and associated logging byStephen R. van den Berg, Aug 12, 2008
  6. git-daemon: Simplify child management and associated logging byStephen R. van den Berg, Aug 13, 2008
  7. Marcus GriepAug 13, 2008
  8. Junio C HamanoAug 13, 2008
  9. Stephen R. van den BergAug 13, 2008
  10. Stephen R. van den BergAug 13, 2008
  11. Junio C HamanoAug 13, 2008
  12. Alex RiesenAug 12, 2008
  13. Stephen R. van den BergAug 12, 2008
  14. Alex RiesenAug 13, 2008
  15. Stephen R. van den BergAug 13, 2008
  16. Andreas EricssonAug 13, 2008
  17. Alex RiesenAug 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.