From: Junio C Hamano Date: Wed, 13 Aug 2008 19:28:55 GMT Subject: Re: [PATCH] git-daemon: Simplify child management and associated logging by Message-ID: <7v8wv0ogso.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20080812225642.GA15265@cuci.nl> "Stephen R. van den Berg" writes: > Junio C Hamano wrote: >>"Stephen R. van den Berg" writes: >>Sorry, but this does too many things in one patch. > > Yes, I know, got carried away. Then again, the code has a lot of > overlapping places (spacewise); I kind of leapt from one place to the > next; you fix one thing, and then the next wart stares you in the face. > I'll see if I can split it up, if that suits you better. > >> - Taking advantage of poll() getting interrupted by SIGCHLD, so that you >> do not have to do anything in the signal handler, is so obvious that I >> am actually ashamed of not having to think of it the last time we >> touched this code. Is there a poll() that does not return EINTR but >> just call the handler and restart after that as if nothing has >> happened, I have to wonder... > > Only if the signal is set to SIG_IGN on all systems I worked with since > 1987. Yeah, rub it in. That's why I said I am actually ashamed that I did not notice that as an obviously much more simpler approach.