git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] compat: introduce stat_to_kilobytes

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 19, 2008, 07:31 UTC
Message-ID
<7v7iadh34x.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<7vbpzqm50b.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 11 quoted lines
> Johannes Sixt <johannes.sixt@telecom.at> writes:
> ...
>> But notice that we now underestimated the size of loose objects more than
>> we did previously because we now round down individual sizes; previously
>> we rounded down only the total size.
>
> Ah, you are right.
>
> Perhaps we should fix this by making the helper stat_to_on_disk_bytes(),
> so that on platform with st_blocks counted in 512-byte blocks we multiply
> it by 512?
I've done this myself and will queue the result.
Previous: Junio C HamanoNext: Andreas Färber
Message 9 of 10 in “Don't use struct stat's st_blocks member on Haiku”
  1. 4/6 Don't use struct stat's st_blocks member on HaikuAndreas Färber, Aug 17, 2008
  2. Jakub NarebskiAug 17, 2008
  3. compat: introduce stat_to_kilobytesJunio C Hamano, Aug 17, 2008
  4. Andreas FärberAug 17, 2008
  5. 1/2 compat: introduce stat_to_kilobytesJohannes Sixt, Aug 18, 2008
  6. 2/2 Revert "Windows: Use a customized struct stat that also has the st_blocks member."Johannes Sixt, Aug 18, 2008
  7. Junio C HamanoAug 18, 2008
  8. Junio C HamanoAug 18, 2008
  9. Junio C HamanoAug 19, 2008
  10. Andreas FärberAug 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.