git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] compat: introduce stat_to_kilobytes

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 18, 2008, 20:40 UTC
Message-ID
<7vbpzqm50b.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200808182157.16392.johannes.sixt@telecom.at>
Johannes Sixt <johannes.sixt@telecom.at> writes:
Show 24 quoted lines
> From: Junio C Hamano <gitster@pobox.com>
>
> Some platforms do not have st_blocks member in "struct stat"; mingw
> already emulates it by rounding it up to closest 512-byte blocks (even
> though it could overcount when a file has holes).
>
> The reason to use the member is only to figure out how many kilobytes the
> file occupies on-disk, so give a helper in git-compat-util.h to help these
> platforms.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> Acked-by: Johannes Sixt <johannes.sixt@telecom.at>
> ---
> On Sonntag, 17. August 2008, Junio C Hamano wrote:
>>    The comment before "struct mingw_stat" suggests that the only reason
>>    this compatiblity definition exists is to add st_blocks member, so I
>>    suspect we could remove the definition and simplify the compatibility
>>    layer a lot more, but I do not know MinGW, so I am CC'ing j6t here.
>
> Makes sense. Here it is again, with the Makefile fixup noted by Andreas.
>
> But notice that we now underestimated the size of loose objects more than
> we did previously because we now round down individual sizes; previously
> we rounded down only the total size.
Ah, you are right.

Perhaps we should fix this by making the helper stat_to_on_disk_bytes(), so that on platform with st_blocks counted in 512-byte blocks we multiply it by 512?

Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 10 in “Don't use struct stat's st_blocks member on Haiku”
  1. 4/6 Don't use struct stat's st_blocks member on HaikuAndreas Färber, Aug 17, 2008
  2. Jakub NarebskiAug 17, 2008
  3. compat: introduce stat_to_kilobytesJunio C Hamano, Aug 17, 2008
  4. Andreas FärberAug 17, 2008
  5. 1/2 compat: introduce stat_to_kilobytesJohannes Sixt, Aug 18, 2008
  6. 2/2 Revert "Windows: Use a customized struct stat that also has the st_blocks member."Johannes Sixt, Aug 18, 2008
  7. Junio C HamanoAug 18, 2008
  8. Junio C HamanoAug 18, 2008
  9. Junio C HamanoAug 19, 2008
  10. Andreas FärberAug 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.