Re: [PATCH 1/2] compat: introduce stat_to_kilobytes
- From
Andreas Färber <andreas.faerber@web.de>
- Date
- Aug 19, 2008, 08:39 UTC
- Message-ID
- <3C98B537-7CD6-4575-8196-1706F8DA049C@web.de>
- In-Reply-To
- <200808182157.16392.johannes.sixt@telecom.at>
Am 18.08.2008 um 21:57 schrieb Johannes Sixt:
Show 26 quoted lines
> From: Junio C Hamano <gitster@pobox.com> > > Some platforms do not have st_blocks member in "struct stat"; mingw > already emulates it by rounding it up to closest 512-byte blocks (even > though it could overcount when a file has holes). > > The reason to use the member is only to figure out how many > kilobytes the > file occupies on-disk, so give a helper in git-compat-util.h to help > these > platforms. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > Acked-by: Johannes Sixt <johannes.sixt@telecom.at> > --- > On Sonntag, 17. August 2008, Junio C Hamano wrote: >> The comment before "struct mingw_stat" suggests that the only >> reason >> this compatiblity definition exists is to add st_blocks member, >> so I >> suspect we could remove the definition and simplify the >> compatibility >> layer a lot more, but I do not know MinGW, so I am CC'ing j6t here. > > Makes sense. Here it is again, with the Makefile fixup noted by > Andreas.
I have tested this on Haiku, compiles okay and simplifies my patches.
Thanks, Andreas