From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 19 Aug 2008 07:31:42 GMT
Subject: Re: [PATCH 1/2] compat: introduce stat_to_kilobytes
Message-ID: <7v7iadh34x.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7vbpzqm50b.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Johannes Sixt <johannes.sixt@telecom.at> writes:
> ...
>> But notice that we now underestimated the size of loose objects more than
>> we did previously because we now round down individual sizes; previously
>> we rounded down only the total size.
>
> Ah, you are right.
>
> Perhaps we should fix this by making the helper stat_to_on_disk_bytes(),
> so that on platform with st_blocks counted in 512-byte blocks we multiply
> it by 512?

I've done this myself and will queue the result.