Re: [PATCH 1/4] Refactoring: remove duplicated code from transport.c and builtin-send-pack.c
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 15, 2010, 06:34 UTC
- Message-ID
- <7v7hqfknwz.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20100215052853.GJ3336@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 27 quoted lines
> On Sun, Feb 14, 2010 at 09:27:40PM +0000, Michael Lukashov wrote: > >> The following functions are duplicated: >> >> verify_remote_names >> update_tracking_ref >> print_ref_status >> status_abbrev >> print_ok_ref_status >> print_one_push_status >> refs_pushed >> print_push_status >> >> Signed-off-by: Michael Lukashov <michael.lukashov@gmail.com> >> --- >> builtin-send-pack.c | 89 ++++++++++++++---------- >> send-pack.h | 20 +++++ >> transport.c | 196 --------------------------------------------------- > > I think this is backwards. The versions in send-pack were there first, > and then were ported to transport.c so that other transports could > benefit from them. And that is where they should ultimately be. > > I can't remember the exact details of why the originals were not > removed, though (I think I complained about it once before, and there > was some technical reason, but I don't recall now). Daniel (cc'd) might > remember more.
Also the names of these functions probably need to be made more specific so that people not so familiar with the transport code can tell that they are from "transport" family. The names didn't matter much while they were file scope static, but this series changes that.