Re: [PATCH 1/4] Refactoring: remove duplicated code from transport.c and builtin-send-pack.c

From: Jeff King <peff@peff.net>
Date: Feb 15, 2010, 07:55 UTC
Message-ID: <20100215075514.GB5347@coredump.intra.peff.net>
In-Reply-To: <7v7hqfknwz.fsf@alter.siamese.dyndns.org>

On Sun, Feb 14, 2010 at 10:34:20PM -0800, Junio C Hamano wrote:

Show 9 quoted lines

> > I can't remember the exact details of why the originals were not
> > removed, though (I think I complained about it once before, and there
> > was some technical reason, but I don't recall now). Daniel (cc'd) might
> > remember more.
> 
> Also the names of these functions probably need to be made more specific
> so that people not so familiar with the transport code can tell that they
> are from "transport" family.  The names didn't matter much while they were
> file scope static, but this series changes that.

Actually, I wonder if we can simply get rid of some of the calls in send-pack. I think that the code in send-pack isn't even called anymore via "git push"; it only gets called when you call send-pack directly. And arguably send-pack as plumbing shouldn't be generating all sorts of user-facing output. But it is a behavior change. I wonder if anybody actually calls send-pack directly anymore. It seems like even scripts use "git push" because of the transport agnosticism.

-Peff