Re: [PATCH 1/4] Refactoring: remove duplicated code from transport.c and builtin-send-pack.c

From: Jeff King <peff@peff.net>
Date: Feb 15, 2010, 05:28 UTC
Message-ID: <20100215052853.GJ3336@coredump.intra.peff.net>
In-Reply-To: <1266182863-5048-1-git-send-email-michael.lukashov@gmail.com>

On Sun, Feb 14, 2010 at 09:27:40PM +0000, Michael Lukashov wrote:

Show 16 quoted lines

> The following functions are duplicated:
> 
>   verify_remote_names
>   update_tracking_ref
>   print_ref_status
>   status_abbrev
>   print_ok_ref_status
>   print_one_push_status
>   refs_pushed
>   print_push_status
> 
> Signed-off-by: Michael Lukashov <michael.lukashov@gmail.com>
> ---
>  builtin-send-pack.c |   89 ++++++++++++++----------
>  send-pack.h         |   20 +++++
>  transport.c         |  196 ---------------------------------------------------

I think this is backwards. The versions in send-pack were there first, and then were ported to transport.c so that other transports could benefit from them. And that is where they should ultimately be.

I can't remember the exact details of why the originals were not removed, though (I think I complained about it once before, and there was some technical reason, but I don't recall now). Daniel (cc'd) might remember more.

-Peff