Re: [PATCH 1/4] Refactoring: remove duplicated code from transport.c and builtin-send-pack.c

From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Date: Feb 15, 2010, 08:46 UTC
Message-ID: <20100215084643.GA26012@Knoppix>
In-Reply-To: <20100215075514.GB5347@coredump.intra.peff.net>

On Mon, Feb 15, 2010 at 02:55:15AM -0500, Jeff King wrote:

Show 5 quoted lines

> On Sun, Feb 14, 2010 at 10:34:20PM -0800, Junio C Hamano wrote:
> 
> Actually, I wonder if we can simply get rid of some of the calls in
> send-pack. I think that the code in send-pack isn't even called anymore
> via "git push"; it only gets called when you call send-pack directly.

Actually, its also seemingly called by git-remote-http(s) (at least it contains references to "stateless RPC", which is related to smart HTTP).

> And arguably send-pack as plumbing shouldn't be generating all sorts of
> user-facing output. But it is a behavior change. I wonder if anybody
> actually calls send-pack directly anymore. It seems like even scripts
> use "git push" because of the transport agnosticism.

For non-stateless case, it seems that the only protocols builtin-send-pack can deal with are ssh://, git:// and file://, it can't deal with any sort of remote helper, not even one provoding smart transport.

-Ilari