git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jun 2012, #01; Sun, 3)

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 11, 2012, 14:54 UTC
Message-ID
<7v7gvdaogr.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAMP44s2US+PoxfboZSML84GEvUwiHV4eQBOQSp6zhruT8xrKdg@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> You say I'm being irresponsible, I say you are being preoccupied by a
> theoretical problem that will not occur, and would not cause any
> problems if it does.

See how the two implementations are different and think what happens when a user dot sources these two scripts in different order. Callers of __gitdir in one expects it to pay attention to GIT_DIR, callers in the other don't, but you can't have both at the same time in the same shell, can you?

It is not theoretical, as you yourself already made it happen.
Get over it.
Previous: Felipe ContrerasNext: Felipe Contreras
Message 7 of 12 in “What's cooking in git.git (Jun 2012, #01; Sun, 3)”
  1. Junio C HamanoJun 4, 2012
  2. Felipe ContrerasJun 6, 2012
  3. Junio C HamanoJun 6, 2012
  4. Felipe ContrerasJun 6, 2012
  5. Junio C HamanoJun 10, 2012
  6. Felipe ContrerasJun 10, 2012
  7. Junio C HamanoJun 11, 2012
  8. Felipe ContrerasJun 13, 2012
  9. Junio C HamanoJun 13, 2012
  10. Felipe ContrerasJun 13, 2012
  11. René ScharfeJun 10, 2012
  12. Felipe ContrerasJun 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.