Re: What's cooking in git.git (Jun 2012, #01; Sun, 3)

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2012, 17:19 UTC
Message-ID: <7v8vfri0xx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s1SOOBHRD7=u78S0dyRMdY0Q=zzkULxoz72ZzBaGC8Fyg@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 16 quoted lines

> On Mon, Jun 11, 2012 at 4:54 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> You say I'm being irresponsible, I say you are being preoccupied by a
>>> theoretical problem that will not occur, and would not cause any
>>> problems if it does.
>>
>> See how the two implementations are different
>
> They are not.
>
> http://git.kernel.org/?p=git/git.git;a=blob;f=contrib/completion/git-completion.bash;h=13690eaecb4d8fafa67b79d33e804e6f8c64d742;hb=refs/heads/pu#l37
>
> http://git.kernel.org/?p=git/git.git;a=blob;f=contrib/completion/git-prompt.sh;h=29b1ec9eb1797e0f2c3c9f7067222432150ba85f;hb=refs/heads/pu#l54
>
> Where is the difference?

Look at your patch that introduces the separate file af31a45 (completion: split __git_ps1 into a separate script, 2012-05-22) instead. The extra $GIT_DIR one in git-completion.sh bba88ea (completion: respect $GIT_DIR, 2012-05-09) is on another topic that is stalled and waiting for a reroll.

And your message brings things back to my exact point.

Unlike the other topic, the topic fc/git-prompt-script we have been discussing is almost ready except for this nit. If we make it graduate to 'master' without doing anything about the other commit, we will have two different versions from day one.

And the worst part of the story is that you are not just placing the burden of noticing and having to worry about these things on other people (in this case, me), but are actively sabotaging the effort to make future mistakes less likely to happen by endlessly bitching and refusing to admit that there is a problem. It seems that it is too difficult for you to admit that you were wrong and say "Yes there is a problem, and among the three approaches you suggested, this is the least intrusive one" or "Yes there is a problem, but I do not like any of the approaches you suggested, so I propose this alternative that is much less intrusive than any of them", and until that happens I do not see a point in talking with you at all.