Re: What's cooking in git.git (Jun 2012, #01; Sun, 3)

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 13, 2012, 14:55 UTC
Message-ID: <CAMP44s1SOOBHRD7=u78S0dyRMdY0Q=zzkULxoz72ZzBaGC8Fyg@mail.gmail.com>
In-Reply-To: <7v7gvdaogr.fsf@alter.siamese.dyndns.org>

On Mon, Jun 11, 2012 at 4:54 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> You say I'm being irresponsible, I say you are being preoccupied by a
>> theoretical problem that will not occur, and would not cause any
>> problems if it does.
>
> See how the two implementations are different

They are not.

http://git.kernel.org/?p=git/git.git;a=blob;f=contrib/completion/git-completion.bash;h=13690eaecb4d8fafa67b79d33e804e6f8c64d742;hb=refs/heads/pu#l37

http://git.kernel.org/?p=git/git.git;a=blob;f=contrib/completion/git-prompt.sh;h=29b1ec9eb1797e0f2c3c9f7067222432150ba85f;hb=refs/heads/pu#l54

Where is the difference?

Show 5 quoted lines

> and think what happens
> when a user dot sources these two scripts in different order. Callers
> of __gitdir in one expects it to pay attention to GIT_DIR, callers in
> the other don't, but you can't have both at the same time in the
> same shell, can you?

So, what you are saying is that we would end up with the "wrong" __gitdir()?

But that "wrong" version is the one that everybody has been using both for completion and prompt since 2006, and *nobody* has complained (except SZEDER, recently).

So, as user, how would having this ancient __gitdir() would affect me? What is this "huge" issue that we want to avoid at all costs?

> It is not theoretical, as you yourself already made it happen.

Nope. I haven't.

Even if I did, what are the *effects*?

> Get over it.

Indeed, please do.

Cheers.

-- 
Felipe Contreras