From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 11 Jun 2012 14:54:28 GMT
Subject: Re: What's cooking in git.git (Jun 2012, #01; Sun, 3)
Message-ID: <7v7gvdaogr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s2US+PoxfboZSML84GEvUwiHV4eQBOQSp6zhruT8xrKdg@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> You say I'm being irresponsible, I say you are being preoccupied by a
> theoretical problem that will not occur, and would not cause any
> problems if it does.

See how the two implementations are different and think what happens
when a user dot sources these two scripts in different order. Callers
of __gitdir in one expects it to pay attention to GIT_DIR, callers in
the other don't, but you can't have both at the same time in the
same shell, can you?

It is not theoretical, as you yourself already made it happen.

Get over it.