git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix cygwin install issues

From
Junio C Hamano <junkio@cox.net>
Date
Oct 10, 2005, 16:51 UTC
Message-ID
<7v64s571t5.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<434A82A0.7060608@zytor.com>
"H. Peter Anvin" <hpa@zytor.com> writes:
Show 10 quoted lines
>> ...  I suspect it might be
>> the responsibility of the user to quote them if she chooses to
>> set bindir or DESTDIR to a funky value, like this:
>>     $ make bindir="'My Documents\Programs'"
>
> I don't think that's the right approach.
>
> 	$(INSTALL) -d -m755 '$(DESTDIR)$(bindir)'
>
> ... at least handles everything except embedded single quotes.

OK. It is better than dq, and the user can still work it around like this if she really wanted to:

	make bindir="Anna'\\''s Home/bin"
I wish we had $(shellquote $(DESTDIR)$(bindir)) in make ;-).
Previous: H. Peter AnvinNext: H. Peter Anvin
Message 7 of 9 in “Fix cygwin install issues”
  1. Fix cygwin install issuesJonas Fonseca, Oct 10, 2005
  2. Jonas FonsecaOct 10, 2005
  3. Junio C HamanoOct 10, 2005
  4. git.sh: quote all pathsJonas Fonseca, Oct 10, 2005
  5. git.sh: quote all pathsJonas Fonseca, Oct 10, 2005
  6. H. Peter AnvinOct 10, 2005
  7. Junio C HamanoOct 10, 2005
  8. H. Peter AnvinOct 10, 2005
  9. Deal with $(bindir) and friends with whitespaces.Junio C Hamano, Oct 10, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.