git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix cygwin install issues

From
HAH. Peter Anvin <hpa@zytor.com>
Date
Oct 10, 2005, 15:02 UTC
Message-ID
<434A82A0.7060608@zytor.com>
In-Reply-To
<7vmzlh7n7h.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 18 quoted lines
> Jonas Fonseca <fonseca@diku.dk> writes:
> 
> 
>>Support installing to paths including spaces.
>>Remove any old .exe files so ln will succeed.
>>
> 
> This is not a complaint but I am just wondering if:
> 
> 
>>-	$(INSTALL) -d -m755 $(DESTDIR)$(bindir)
>>+	$(INSTALL) -d -m755 "$(DESTDIR)$(bindir)"
> 
> this is the right way to quote things.  I suspect it might be
> the responsibility of the user to quote them if she chooses to
> set bindir or DESTDIR to a funky value, like this:
> 
>     $ make bindir="'My Documents\Programs'"
I don't think that's the right approach.
	$(INSTALL) -d -m755 '$(DESTDIR)$(bindir)'

... at least handles everything except embedded single quotes. Note that the single quote is not a special character for make.

Show 7 quoted lines
> Because depending on how funky the values of bindir and DESTDIR
> are, we cannot say double-quote you are giving them is even the
> right quoting (think double-quote itself as part of the name).
> 
> The other "$X" change to cmd-renames is a good change (I thought
> I heard HPA talking about that; maybe he sent one to me and I
> dropped it on the floor by mistake, I dunno).  Thanks.
If I dropped it on the floor, it was mentally :-/
	-hpa
Previous: Jonas FonsecaNext: Junio C Hamano
Message 6 of 9 in “Fix cygwin install issues”
  1. Fix cygwin install issuesJonas Fonseca, Oct 10, 2005
  2. Jonas FonsecaOct 10, 2005
  3. Junio C HamanoOct 10, 2005
  4. git.sh: quote all pathsJonas Fonseca, Oct 10, 2005
  5. git.sh: quote all pathsJonas Fonseca, Oct 10, 2005
  6. H. Peter AnvinOct 10, 2005
  7. Junio C HamanoOct 10, 2005
  8. H. Peter AnvinOct 10, 2005
  9. Deal with $(bindir) and friends with whitespaces.Junio C Hamano, Oct 10, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.