From: Junio C Hamano <junkio@cox.net>
Date: Mon, 10 Oct 2005 16:51:34 GMT
Subject: Re: [PATCH] Fix cygwin install issues
Message-ID: <7v64s571t5.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <434A82A0.7060608@zytor.com>

"H. Peter Anvin" <hpa@zytor.com> writes:

>> ...  I suspect it might be
>> the responsibility of the user to quote them if she chooses to
>> set bindir or DESTDIR to a funky value, like this:
>>     $ make bindir="'My Documents\Programs'"
>
> I don't think that's the right approach.
>
> 	$(INSTALL) -d -m755 '$(DESTDIR)$(bindir)'
>
> ... at least handles everything except embedded single quotes.

OK.  It is better than dq, and the user can still work it around
like this if she really wanted to:

	make bindir="Anna'\\''s Home/bin"

I wish we had $(shellquote $(DESTDIR)$(bindir)) in make ;-).