Re: [PATCH] Fix cygwin install issues

From: Junio C Hamano <junkio@cox.net>
Date: Oct 10, 2005, 09:09 UTC
Message-ID: <7vmzlh7n7h.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20051010085259.GA18009@diku.dk>

Jonas Fonseca <fonseca@diku.dk> writes:

> Support installing to paths including spaces.
> Remove any old .exe files so ln will succeed.
>

This is not a complaint but I am just wondering if:

> -	$(INSTALL) -d -m755 $(DESTDIR)$(bindir)
> +	$(INSTALL) -d -m755 "$(DESTDIR)$(bindir)"

this is the right way to quote things. I suspect it might be the responsibility of the user to quote them if she chooses to set bindir or DESTDIR to a funky value, like this:

    $ make bindir="'My Documents\Programs'"

Because depending on how funky the values of bindir and DESTDIR are, we cannot say double-quote you are giving them is even the right quoting (think double-quote itself as part of the name).

The other "$X" change to cmd-renames is a good change (I thought I heard HPA talking about that; maybe he sent one to me and I dropped it on the floor by mistake, I dunno). Thanks.