git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Mark Levedahl's gitk patches

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 27, 2007, 00:41 UTC
Message-ID
<7v645axm7r.fsf@assigned-by-dhcp.pobox.com>
In-Reply-To
<18048.36797.283166.952377@cargo.ozlabs.ibm.com>
Paul Mackerras <paulus@samba.org> writes:
Show 9 quoted lines
> Mark Levedahl writes:
>
>> I found a bug in the highlight patch (the color picker updated the wrong 
>> panel in the chooser but did set the correct color), and updated the 
>> tab-stop patch to use a spin control to enforce entry of small integers 
>> only. As there is possible interest, I am sending the amended series.
>
> Ah.  I just pushed out a pile of patches to gitk.git including your
> three.  Could you do an incremental patch on top of that for me?

I took a look at differences between your gitk.git and what I have. It appears that our "proc readrefs" differ a bit.

Most notably, the global hash tagcontents is read when readrefs run in the version I have, while gitk.git version fills it lazily in showtag, where it is actually used. Because you read the refs using "show-ref -d", you do not need to do extra forks to figure out the objects referred to by the tags in your code.

I think what you have is a lot better from interactive latency point of view. I'll take the version from gitk.git and push the results out.

Previous: Paul MackerrasNext: Paul Mackerras
Message 8 of 11 in “Mark Levedahl's gitk patches”
  1. Johannes SixtJun 25, 2007
  2. Mark LevedahlJun 26, 2007
  3. gitk - Make selection highlight color configurableMark Levedahl, Jun 26, 2007
  4. gitk - Update fontsize in patch / tree listMark Levedahl, Jun 26, 2007
  5. gitk - Allow specifying tabstop as other than default 8 characters.Mark Levedahl, Jun 26, 2007
  6. Brian DowningJun 26, 2007
  7. Paul MackerrasJun 26, 2007
  8. Junio C HamanoJun 27, 2007
  9. Paul MackerrasJun 28, 2007
  10. gitk - bugfix - Update selection background colorbar in prefs dialogMark Levedahl, Jun 27, 2007
  11. gitk - Use a spinbox for setting tabstop settingsMark Levedahl, Jun 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.