Re: Mark Levedahl's gitk patches
- From
Paul Mackerras <paulus@samba.org>
- Date
- Jun 28, 2007, 00:15 UTC
- Message-ID
- <18050.64921.235580.37028@cargo.ozlabs.ibm.com>
- In-Reply-To
- <7v645axm7r.fsf@assigned-by-dhcp.pobox.com>
Junio C Hamano writes:
Show 8 quoted lines
> I took a look at differences between your gitk.git and what I > have. It appears that our "proc readrefs" differ a bit. > > Most notably, the global hash tagcontents is read when readrefs > run in the version I have, while gitk.git version fills it > lazily in showtag, where it is actually used. Because you read > the refs using "show-ref -d", you do not need to do extra forks > to figure out the objects referred to by the tags in your code.
Yes, that was one of the many improvements I made. Basically I pulled a lot of stuff over from the 'new' branch.
> I think what you have is a lot better from interactive latency > point of view. I'll take the version from gitk.git and push the > results out.
Thanks. I have now pushed out Mark Levedahl's two bug fixes as well.
Paul.