git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk - Make selection highlight color configurable

From
Brian Downing <bdowning@lavos.net>
Date
Jun 26, 2007, 17:54 UTC
Message-ID
<20070626175452.GS4087@lavos.net>
In-Reply-To
<1182825801300-git-send-email-mdl123@verizon.net>
Mark Levedahl wrote:
Show 5 quoted lines
> Cygwin's tk by default uses a very dark selection background color
> that makes the currently selected text almost unreadable. On linux,
> the default selection background is a light gray which is very usable.
> This makes the default a light gray everywhere but allows the user to
> configure the color as well.

I noticed this, and also noticed that the dark color in question was in fact the default Windows selection background color. Unfortunately, wish/gitk doesn't also use the default Windows selection foreground color (white), so the result is pretty unreadable.

When playing with Git on Windows I worked around the problem by changing the selection color system-wide.

(This patch is perhaps better than making it work the "Windows way" with the right system foreground color, though, as the tag and branch markers are also pretty ugly against a dark background...)

-bcd
-- 
*** Brian Downing <bdowning@lavos.net>
Previous: Mark LevedahlNext: Paul Mackerras
Message 6 of 11 in “Mark Levedahl's gitk patches”
  1. Johannes SixtJun 25, 2007
  2. Mark LevedahlJun 26, 2007
  3. gitk - Make selection highlight color configurableMark Levedahl, Jun 26, 2007
  4. gitk - Update fontsize in patch / tree listMark Levedahl, Jun 26, 2007
  5. gitk - Allow specifying tabstop as other than default 8 characters.Mark Levedahl, Jun 26, 2007
  6. Brian DowningJun 26, 2007
  7. Paul MackerrasJun 26, 2007
  8. Junio C HamanoJun 27, 2007
  9. Paul MackerrasJun 28, 2007
  10. gitk - bugfix - Update selection background colorbar in prefs dialogMark Levedahl, Jun 27, 2007
  11. gitk - Use a spinbox for setting tabstop settingsMark Levedahl, Jun 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.