git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitk - bugfix - Update selection background colorbar in prefs dialog

From
Mark Levedahl <mdl123@verizon.net>
Date
Jun 27, 2007, 01:51 UTC
Message-ID
<11829090952211-git-send-email-mdl123@verizon.net>
In-Reply-To
<18048.36797.283166.952377@cargo.ozlabs.ibm.com>

The callback function was incorrectly set to update the background colorbar when updated the selection background. This did not affect the colors chosen or their use, just their presentation in the preferences dialog box.

Signed-off-by: Mark Levedahl <mdl123@verizon.net>
---
 gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitk b/gitk
index 269f9b0..c06d327 100755
--- a/gitk
+++ b/gitk
@@ -7004,7 +7004,7 @@ proc doprefs {} {
     grid x $top.hunksepbut $top.hunksep -sticky w
     label $top.selbgsep -padx 40 -relief sunk -background $selectbgcolor
     button $top.selbgbut -text "Select bg" -font optionfont \
-	-command [list choosecolor selectbgcolor 0 $top.bg background setselbg]
+	-command [list choosecolor selectbgcolor 0 $top.selbgsep background setselbg]
     grid x $top.selbgbut $top.selbgsep -sticky w
 
     frame $top.buts
-- 
1.5.2.2.282.g9826
Previous: Paul MackerrasNext: Mark Levedahl
Message 10 of 11 in “Mark Levedahl's gitk patches”
  1. Johannes SixtJun 25, 2007
  2. Mark LevedahlJun 26, 2007
  3. gitk - Make selection highlight color configurableMark Levedahl, Jun 26, 2007
  4. gitk - Update fontsize in patch / tree listMark Levedahl, Jun 26, 2007
  5. gitk - Allow specifying tabstop as other than default 8 characters.Mark Levedahl, Jun 26, 2007
  6. Brian DowningJun 26, 2007
  7. Paul MackerrasJun 26, 2007
  8. Junio C HamanoJun 27, 2007
  9. Paul MackerrasJun 28, 2007
  10. gitk - bugfix - Update selection background colorbar in prefs dialogMark Levedahl, Jun 27, 2007
  11. gitk - Use a spinbox for setting tabstop settingsMark Levedahl, Jun 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.