git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/5] pretty: format aliases

From
Junio C Hamano <gitster@pobox.com>
Date
May 2, 2010, 03:12 UTC
Message-ID
<7v39yb0zfh.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1272656128-2002-1-git-send-email-wmpalmer@gmail.com>
Thanks.  Overall I like the direction this is going.

There however are too many style violations that I prefer not to fix myself.

 * Format if/while/switch etc. like this:
	if (expression) {
        	statement;
                ...
	}
   not like this:
	if( expression ){
        	...
   - Have one SP between syntactic keyword and an open parenthesis;
   - Do not have extra SP before or after the expression inside
     parentheses;
   - Have one SP between a close parenthesis and an open brace.
 * do not initialise statics to 0 or NULL; e.g. not like
    
	static size_t commit_formats_len = 0;
   but like
	static size_t commit_formats_len;
 * Do not omit SP around operators.
	for (i = 0; i < builtin_formats_len; i++) {
        	...
   I.e. not like this:
	for (i=0; i<builtin_formats_len; i++) {
Previous: Jeff King
Message 21 of 21 in “pretty: format aliases”
  1. 0/5 pretty: format aliasesWill Palmer, Apr 30, 2010
  2. 1/5 pretty: add conditional %C?colorname placeholdersWill Palmer, Apr 30, 2010
  3. Junio C HamanoMay 2, 2010
  4. Will PalmerMay 2, 2010
  5. 2/5 pretty: make %H/%h/etc respect --abbrev[-commit]Will Palmer, Apr 30, 2010
  6. Junio C HamanoMay 2, 2010
  7. Jeff KingMay 2, 2010
  8. Junio C HamanoMay 2, 2010
  9. Jeff KingMay 2, 2010
  10. Will PalmerMay 2, 2010
  11. Will PalmerMay 2, 2010
  12. Junio C HamanoMay 2, 2010
  13. Jonathan NiederMay 2, 2010
  14. 3/5 pretty: make it easier to add new formatsWill Palmer, Apr 30, 2010
  15. 4/5 pretty: add infrastructure to allow format aliasesWill Palmer, Apr 30, 2010
  16. Junio C HamanoMay 2, 2010
  17. Will PalmerMay 2, 2010
  18. 5/5 pretty: add aliases for pretty formatsWill Palmer, Apr 30, 2010
  19. Junio C HamanoMay 2, 2010
  20. Jeff KingMay 2, 2010
  21. Junio C HamanoMay 2, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.