From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 02 May 2010 03:12:34 GMT
Subject: Re: [PATCH v3 0/5] pretty: format aliases
Message-ID: <7v39yb0zfh.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1272656128-2002-1-git-send-email-wmpalmer@gmail.com>

Thanks.  Overall I like the direction this is going.

There however are too many style violations that I prefer not to fix
myself.

 * Format if/while/switch etc. like this:

	if (expression) {
        	statement;
                ...
	}

   not like this:

	if( expression ){
        	...

   - Have one SP between syntactic keyword and an open parenthesis;
   - Do not have extra SP before or after the expression inside
     parentheses;
   - Have one SP between a close parenthesis and an open brace.

 * do not initialise statics to 0 or NULL; e.g. not like
    
	static size_t commit_formats_len = 0;

   but like

	static size_t commit_formats_len;

 * Do not omit SP around operators.

	for (i = 0; i < builtin_formats_len; i++) {
        	...

   I.e. not like this:

	for (i=0; i<builtin_formats_len; i++) {