Re: [PATCH v3 2/5] pretty: make %H/%h/etc respect --abbrev[-commit]

From: Jeff King <peff@peff.net>
Date: May 2, 2010, 04:45 UTC
Message-ID: <20100502044506.GA14776@coredump.intra.peff.net>
In-Reply-To: <7vocgzyp1f.fsf@alter.siamese.dyndns.org>

On Sat, May 01, 2010 at 08:13:00PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Will Palmer <wmpalmer@gmail.com> writes:
> 
> > Prior to this, the output of %H was always 40 characters long, and the
> > output of %h always DEFAULT_ABBREV characters long, without regard to
> > whether --abbrev-commit or --abbrev had been passed.
> >
> > Here we make "git log --pretty=%H --abbrev-commit" synonymous with
> > "git log --pretty=%h", and make %h/abbreviated-%H respect the length
> > specified for --abbrev.
> 
> I think it is a good change to make %h follow --abbrev, but %H should stay
> the full length no matter what (otherwise why would anybody use %H not %h?).

But I thought the point of %h was to be abbreviated? If it follows --abbrev, then "git log --format=%h" would show the full sha1, no?

-Peff